Topic: Please fix warnings and wp requirements in code

Hi there,

I like to congratulate you for developing perhaps the best free magazine theme I could find for wordpress. Keep up the great work!
The only problem I have so far are a few errors and warnings I got when running it through the wp theme check plugin.

I am sure they are not a major problem but I believe it would be good to fix those as you may lose some users because of that. Maybe it also fixes possible bugs or problems with some plugins or simply speeds up the theme..and save you some debugging time..

Many thanks again for creating it!  smile

Here is what I got with the Arras theme 1.5.0.1 in WP 3.1.2:

    * WARNING: TimThumb detected in file library/timthumb.php. Version 1.12 is out of date!
    * WARNING: Found ini_set in the file library/timthumb.php. Themes should not change server PHP settings.

      Line 25: ini_set('display_errors', 1);

      Line 89: ini_set('memory_limit', '50M');

      Line 299: @ini_set ('gd.jpeg_ignore_warning', 1);

    * WARNING: Found @shell_exec in the file library/timthumb.php. PHP sytem calls should be disabled by server admins anyway!.

      Line 396: $mime_type = trim(@shell_exec('file -bi ' . escapeshellarg($file)));

    * WARNING: fopen was found in the file library/timthumb.php possible file operations.

      Line 573: $fh = fopen($local_filepath, 'w');

    * REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support

       <?php add_theme_support( $feature ); ?>

    * REQUIRED: wp_specialchars found in the file search.php. Deprecated since version 2.8. Use esc_html() instead.

      Line 10: <p><?php printf( __('Search Results for <strong>‘' . '%s' . '’</strong></p>', 'arras'), wp_specialchars($s, 1) ) ?>

    * REQUIRED: wp_specialchars found in the file library/filters.php. Deprecated since version 2.8. Use esc_html() instead.

      Line 152: <input type='submit' class='searchsubmit' value='' . __('Search', 'arras') . '' title='' . sprintf( __('Search %s', 'arras'), wp_specialchars( get_bloginfo('name'), 1 ) ) . '' />

    * REQUIRED: library/admin/admin.php. Themes should use add_theme_page() for adding admin pages.

      Line 25: $options_page = add_menu_page( '', __('Arras', 'arras'), 'switch_themes', 'arras-options',

    * REQUIRED: .sticky css class is needed in your theme css.
    * REQUIRED: .bypostauthor css class is needed in your theme css.
    * RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
    * RECOMMENDED: Text domain problems in library/widgets.php. You have not included a text domain!

      Line 417: $title = __('Tags');

    * RECOMMENDED: Screenshot is wrong size! Detected: 300x255px. Maximum allowed size is 320x240px.
    * RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
    * RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
    * RECOMMENDED: get_bloginfo(url) was found in the file library/filters.php. Use home_url() instead.
    * RECOMMENDED: get_bloginfo(url) was found in the file library/admin/admin.php. Use home_url() instead.
    * RECOMMENDED: get_bloginfo(url) was found in the file header.php. Use home_url() instead.
    * RECOMMENDED: get_bloginfo(template_url) was found in the file library/styles.php. Use get_template_directory_uri() instead.
    * RECOMMENDED: get_bloginfo(template_directory) was found in the file library/thumbnails.php. Use get_template_directory_uri() instead.
    * RECOMMENDED: get_bloginfo(template_directory) was found in the file library/admin/admin.php. Use get_template_directory_uri() instead.
    * RECOMMENDED: bloginfo(url) was found in the file searchform.php. Use echo home_url() instead.
    * RECOMMENDED: bloginfo(url) was found in the file library/admin/templates/arras-design.php. Use echo home_url() instead.
    * RECOMMENDED: bloginfo(url) was found in the file header.php. Use echo home_url() instead.
    * RECOMMENDED: bloginfo(template_url) was found in the file library/styles.php. Use get_template_directory_uri() instead.
    * RECOMMENDED: bloginfo(template_directory) was found in the file library/admin/background.php. Use get_template_directory_uri() instead.
    * RECOMMENDED: bloginfo(template_directory) was found in the file library/admin/admin.php. Use get_template_directory_uri() instead.
    * RECOMMENDED: Tags: is either empty or missing in style.css header.
    * INFO: Possible hard-coded links were found in the file library/admin/templates/taxonomy_page.php.

      Line 11: <form enctype='multipart/form-data' id='arras-posttax-form' class='ui-widget-content' method='post' action='admin.php?page=arras-posttax'>

      Line 15: <li class='ui-state-default ui-corner-top'><a href='admin.php?page=arras-posttax'><?php _e('Post Types', 'arras') ?></a></li>

      Line 16: <li class='ui-state-default ui-corner-top ui-tabs-selected ui-state-active'><a href='admin.php?page=arras-posttax&type=taxonomy'><?php _e('Taxonomies', 'arras')

    * INFO: Possible hard-coded links were found in the file library/admin/templates/posttype_page.php.

      Line 22: <form enctype='multipart/form-data' id='arras-posttax-form' class='ui-widget-content' method='post' action='admin.php?page=arras-posttax'>

      Line 26: <li class='ui-state-default ui-corner-top ui-tabs-selected ui-state-active'><a href='admin.php?page=arras-posttax'><?php _e('Post Types', 'arras') ?></a></li>

      Line 27: <li class='ui-state-default ui-corner-top'><a href='admin.php?page=arras-posttax&type=taxonomy'><?php _e('Taxonomies', 'arras')

    * INFO: Possible hard-coded links were found in the file library/admin/templates/arras-navigation.php.

      Line 19: <p><?php printf( __('It is highly recommended that you use the %s for better control of the main navigation.', 'arras'), '<a href='http://pixopoint.com/multi-level-navigation/'>Multi-level Navigation Plugin

    * INFO: Possible hard-coded links were found in the file library/admin/templates/arras-general.php.

      Line 33: <?php _e('This will replace the default WordPress RSS feed to this. Useful if you have decided to use third-party services like <a href='http://feedburner.google.com/'>Feedburner</a>.', 'arras') ?>

      Line 41: <?php _e('This will replace the default WordPress RSS comments feed to this. Useful if you have decided to use third-party services like <a href='http://feedburner.google.com/'>Feedburner</a>.', 'arras') ?>

    * INFO: Possible hard-coded links were found in the file library/admin/admin.php.

      Line 261: <li><a href='http://www.arrastheme.com/wiki/doku.php/quick_start_guide'><?php _e('Quick

    * INFO: At least one hard coded date was found in the file library/tapestries.php. Consider get_option( 'date_format' )

Thumbs up